-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle delete statement in python frontend #1723
Merged
oxisto
merged 10 commits into
main
from
ls/1709-handle-delete-statement-in-python-frontend
Sep 25, 2024
Merged
Handle delete statement in python frontend #1723
oxisto
merged 10 commits into
main
from
ls/1709-handle-delete-statement-in-python-frontend
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lshala
requested review from
maximiliankaul,
konradweiss,
oxisto and
KuechA
as code owners
September 24, 2024 13:51
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
oxisto
reviewed
Sep 24, 2024
...ore/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/statements/expressions/DeleteExpression.kt
Outdated
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
oxisto
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can ignore the test coverage here because it was because of missing C++ coverage
…ontends/python/StatementHandler.kt Co-authored-by: Maximilian Kaul <[email protected]>
Quality Gate failedFailed conditions |
oxisto
deleted the
ls/1709-handle-delete-statement-in-python-frontend
branch
September 25, 2024 15:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for handling
delete
statements in Python.Fixes #1709